[lnkForumImage]
TotalShareware - Download Free Software

Confronta i prezzi di migliaia di prodotti.
Asp Forum
 Home | Login | Register | Search 


 

Forums >

comp.lang.ruby

Better way to do this?

Pito Salas

2/12/2009 10:25:00 PM

Hi,

I seem to be repeating myself in the following little bit:

if (!@options[:namespace].nil?)
namespace_options = @options[:namespace]
root.add_namespace(namespace_options[:namespace],
namespace_options[:value])
end

Can someone show me a way to not repeat options[:namespace] ?

Simpler example of the exact same:

if (!hash[:value].nil?)
h = hash[:value]
puts h[:left], h[:right]
end

Thanks for any tips for writing more idiomatic ruby!
--
Posted via http://www.ruby-....

3 Answers

Joel VanderWerf

2/12/2009 10:42:00 PM

0

Pito Salas wrote:
> Hi,
>
> I seem to be repeating myself in the following little bit:
>
> if (!@options[:namespace].nil?)
> namespace_options = @options[:namespace]
> root.add_namespace(namespace_options[:namespace],
> namespace_options[:value])
> end
>
> Can someone show me a way to not repeat options[:namespace] ?
>
> Simpler example of the exact same:
>
> if (!hash[:value].nil?)
> h = hash[:value]
> puts h[:left], h[:right]
> end

hash = {
:value => {:left => 1, :right => 2}
}

# original:
if (!hash[:value].nil?)
h = hash[:value]
puts h[:left], h[:right]
end

# looking up :value only once
h = hash[:value]
if h ## assuming you don't use false as a value in the hash
puts h[:left], h[:right]
end

# living a little dangerously (assignment in conditional):
if (h = hash[:value])
puts h[:left], h[:right]
end

# more compactly, if you care:
h = hash[:value] and puts h[:left], h[:right]

# the last one depends on 'and' having low precedence (unlike &&)

--
vjoel : Joel VanderWerf : path berkeley edu : 510 665 3407

Bertram Scharpf

2/12/2009 10:43:00 PM

0

Hi,

Am Freitag, 13. Feb 2009, 07:24:59 +0900 schrieb Pito Salas:
>
> if (!hash[:value].nil?)
> h = hash[:value]
> puts h[:left], h[:right]
> end

Untested:

if (!(h = hash[:value]).nil?)
puts h[:left], h[:right]
end

or

h = hash[:value]
unless h.nil? then
puts h[:left], h[:right]
end

or

h = hash[:value]
h.nil? or puts h[:left], h[:right]

Hope you enjoyed the trip.

Bertram


--
Bertram Scharpf
Stuttgart, Deutschland/Germany
http://www.bertram-...

Tim Pease

2/12/2009 10:44:00 PM

0

On Feb 12, 2009, at 3:24 PM, Pito Salas wrote:

> Hi,
>
> I seem to be repeating myself in the following little bit:
>
> if (!@options[:namespace].nil?)
> namespace_options = @options[:namespace]
> root.add_namespace(namespace_options[:namespace],
> namespace_options[:value])
> end
>
> Can someone show me a way to not repeat options[:namespace] ?
>
> Simpler example of the exact same:
>
> if (!hash[:value].nil?)
> h = hash[:value]
> puts h[:left], h[:right]
> end
>

if (h = hash[:value])
puts h[:left], h[:right]
end


Blessings,
TwP