[lnkForumImage]
TotalShareware - Download Free Software
Confronta i prezzi di migliaia di prodotti.
Asp Forum
 Home | Login | Register | Search 


 

Forums >

comp.lang.ruby

hpricot 0.4.76 chokes on empty comment.

Ron M

12/5/2006 1:12:00 AM

Hpricot's choking on some pages complaining about nil
in Comment#parse. I can't remember the HTML page that
was parsing it; but this patch fixes the problem for me.

Why? If you're around, should something like this be checked
in the main project?

Ron


desktop2:/usr/local/lib/ruby/gems/1.8/gems/hpricot-0.4.76/lib/hpricot% diff -c parse.rb.orig parse.rb
*** parse.rb.orig Fri Dec 1 16:53:58 2006
--- parse.rb Fri Dec 1 16:54:04 2006
***************
*** 261,267 ****

def Comment.parse(content)
result = Comment.new(content)
! result.raw_string = "<!--" + content + "-->"
result
end

--- 261,267 ----

def Comment.parse(content)
result = Comment.new(content)
! result.raw_string = "<!--" + (content||'') + "-->"
result
end
1 Answer

_why

12/5/2006 4:28:00 PM

0

On Tue, Dec 05, 2006 at 10:11:42AM +0900, Ron M wrote:
> Hpricot's choking on some pages complaining about nil
> in Comment#parse. I can't remember the HTML page that
> was parsing it; but this patch fixes the problem for me.
>
> Why? If you're around, should something like this be checked
> in the main project?

It's in. Way to be, Ron!

_why