[lnkForumImage]
TotalShareware - Download Free Software
Confronta i prezzi di migliaia di prodotti.
Asp Forum
 Home | Login | Register | Search 


 

Forums >

comp.lang.ruby

[MacOS X][ANN] RAliasFile Initial Release

pere.noel

8/30/2006 11:04:00 AM

RAliasFile is aimed to resolve alias file on Mac OS X using a C
extension to ruby.

see <http://rubyforge.org/frs/?group_id=2129&release_i...

I'd be glad hearing comments upon it.

next plan :

do a RAliasRecord extension to Ruby
--
une bévue
7 Answers

Luc Heinrich

8/30/2006 2:09:00 PM

0

On 30 août 06, at 13:05, Une bévue wrote:

> I'd be glad hearing comments upon it.

Ok, here we go:

1. The RUBY_PLATFORM test in your extconf.rb file is broken. It will
only allow to build the extension for a ruby *built* under 10.4.7.
For example, it will fail for a ruby built on 10.4.6 but running
under 10.4.7. And the regexp you are using is incorrect to begin with
('.' does not match '.', but any character).

2. You are adding include paths to CFLAGS which you don't need. Only
Carbon and CoreFoundation are required, you can remove everything else.

3. Same for LDFLAGS, you only need to link against the Carbon and
CoreFoundation frameworks, forget about CoreServices and Foundation.

4. I have no idea how your extension can work, because it really
should not. You are defining methods for RAliasFile which is a global
variable set to Qnil, instead of defining them for cRAliasFile which
you correctly define first. This makes no sense. Remove RAliasFile,
you don't need it.

5. Same story for the alias_path global variable, it's totally
useless as far as I can tell.

6. Having "version" as an instance method is bogus, you should
probably make it a singleton method.


That's after a quick 5mn look, there's probably more to say... :)

--
Luc Heinrich - luc@honk-honk.com - http://www.hon...

pere.noel

8/30/2006 3:28:00 PM

0

Luc Heinrich <luc@honk-honk.com> wrote:

> Ok, here we go:
>
> 1. The RUBY_PLATFORM test in your extconf.rb file is broken. It will
> only allow to build the extension for a ruby *built* under 10.4.7.
> For example, it will fail for a ruby built on 10.4.6 but running
> under 10.4.7. And the regexp you are using is incorrect to begin with
> ('.' does not match '.', but any character).

ok, i've corrected that to /powerpc-darwin8\.\d\.\d/

>
> 2. You are adding include paths to CFLAGS which you don't need. Only
> Carbon and CoreFoundation are required, you can remove everything else.
>
> 3. Same for LDFLAGS, you only need to link against the Carbon and
> CoreFoundation frameworks, forget about CoreServices and Foundation.

ok corrected

> 4. I have no idea how your extension can work, because it really
> should not. You are defining methods for RAliasFile which is a global
> variable set to Qnil, instead of defining them for cRAliasFile which
> you correctly define first. This makes no sense. Remove RAliasFile,
> you don't need it.
>
> 5. Same story for the alias_path global variable, it's totally
> useless as far as I can tell.

ok too...

> 6. Having "version" as an instance method is bogus, you should
> probably make it a singleton method.

fixed ))

thanks a lot for your help, i now have a 0.0.2 version ...
--
une bévue

Austin Ziegler

8/30/2006 8:18:00 PM

0

On 8/30/06, Une bévue <pere.noel@laponie.com.invalid> wrote:
> ok, i've corrected that to /powerpc-darwin8\.\d\.\d/

That won't work on my Mac, will it? (Checking.) Nope. My platform is
i686-darwin8.7.1. So unless you're *only* wanting this to work on
older Macs, you'll need to have /.*-darwin8.*/ (if darwin8 is the
right version; darwin may be the right choice).

I haven't *tried* it, yet -- too much work to do today -- but just a note.

-austin
--
Austin Ziegler * halostatue@gmail.com * http://www.halo...
* austin@halostatue.ca * http://www.halo...feed/
* austin@zieglers.ca

pere.noel

8/30/2006 8:57:00 PM

0

Austin Ziegler <halostatue@gmail.com> wrote:

> That won't work on my Mac, will it? (Checking.) Nope. My platform is
> i686-darwin8.7.1. So unless you're *only* wanting this to work on
> older Macs, you'll need to have /.*-darwin8.*/ (if darwin8 is the
> right version; darwin may be the right choice).
>
> I haven't *tried* it, yet -- too much work to do today -- but just a note.

fine thanks for this point, i can change it quickly.
--
une bévue

Luc Heinrich

9/1/2006 3:26:00 PM

0

On 1 sept. 06, at 07:43, Yvon Thoraval wrote:

> change line 6 (just after "case RUBY_PLATFORM") to :
>
> when /.*-darwin8.*/

Ok now let's push this a bit further: why are you limiting the
compilation to Tiger ? You don't seem to use any Tiger specific call,
not to mention the fact that you are limiting compilation to Tiger
*only* so Leopard users won't be able to compile it either. Just
remove the test, it's useless :)

--
Luc Heinrich - luc@honk-honk.com - http://www.hon...

pere.noel

9/1/2006 4:25:00 PM

0

Luc Heinrich <luc@honk-honk.com> wrote:

> Ok now let's push this a bit further: why are you limiting the
> compilation to Tiger ?

i just want a user of not Mac OS X to be advice this prog works only on
Mac OS X.

that's the "8" preventing compilation over Leopard ?
--
une bévue

Luc Heinrich

9/1/2006 7:00:00 PM

0

On 1 sept. 06, at 18:25, Une bévue wrote:

> i just want a user of not Mac OS X to be advice this prog works
> only on
> Mac OS X.

Ah, good point.

> that's the "8" preventing compilation over Leopard ?

I would expect so, yes.

--
Luc Heinrich - luc@honk-honk.com - http://www.hon...